Print opam variables (os, os-distribution, os-family, ...) in Windows workflows #28806
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
added
github_actions
|
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 1-liner prints relevant opam variables (
os,os-distribution,os-family, ...) in the Windows workflows.The opam-repo-ci workflows already do something similar (
opam config report), so it makes sense to do something similar under Windows.opam config reportdoesn't printos-familythough, which I think is particular relevant under Windows (#28804, #28805).This reveals why
conf-libpcreisn't working under MinGW MSys #28769 (review):os-distributionis"msys2"there, not"cygwin", causing the wrongbuildcommand to trigger.Looking more into this, I found that this changed in ocaml/opam#5843 with opam.2.2.
It however means I have some
conf-file correcting to do... 😅FTR, the wiki is already correct about
os-distributionunder MSys2:https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values
One could add a note about the value changing from opam.2.2 though (I don't have write access to do so).